Updated BLERemoteCharacteristic to exposre esp_gatt_auth_req_t parame… #3531
Conversation
…ter for readValue and writeValue.
There was a problem hiding this comment.
Better way to do that would be to add function to setup auth value in class, because auth level wont change over connection time, with default value set to NONE. This way code will be kept more clean and you dont have to pass additional argument over and over each time you read, write characteristic.
Beside that good improvement, thanks for contribution.
|
Makes sense, which class should be setup with it? BLEDevice, BLERemoteService or BLERemoteCharacteristic? I guess the question here is would the auth likely be the same for connections with client, all services or just for a single characteristic. Thank you - and I'd be more than happy to update the PR based on your feedback. |
|
BLERemoteCharacteristic and probably BLERemoteDescriptor too to make it consistent. This of course will require to call function to set required auth for each characteristic, but according to bluetooth specs some characteristics cant have auth set to other than NONE. |
|
Thank you for the quick response and guidance. I will update the PR and resubmit for reconsideration later today. |
… to allow tweaking the authentication request type for that remotecharacteristic/descriptor without the need to add auth on each read/write.
|
I updated the PR to not have auth on each read/write as suggested but rather as a private variable for BLERemoteCharacteristic/Descriptor, which is defaulted to none when created and can be modified via setAuth. |
For a project, I needed to be able to specify the esp_gatt_auth_req_t parameter for read and write value. I thought this might be valuable to others and I am therefore submitting a pull request for consideration.